fix: add in v1beta1 termination metrics label (aws#606)

gfcroft · Oct 16, 2023 · 7e01cfb · 7e01cfb
1 parent c93b071
commit 7e01cfb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/controllers/node/termination/controller.go b/pkg/controllers/node/termination/controller.go
@@ -148,6 +148,7 @@ func (c *Controller) removeFinalizer(ctx context.Context, n *v1.Node) error {
 		// We use stored.DeletionTimestamp since the api-server may give back a node after the patch without a deletionTimestamp
 		TerminationSummary.With(prometheus.Labels{
 			metrics.ProvisionerLabel: n.Labels[v1alpha5.ProvisionerNameLabelKey],
+			metrics.NodePoolLabel:    n.Labels[v1beta1.NodePoolLabelKey],
 		}).Observe(time.Since(stored.DeletionTimestamp.Time).Seconds())
 		logging.FromContext(ctx).Infof("deleted node")
 	}

diff --git a/pkg/controllers/node/termination/metrics.go b/pkg/controllers/node/termination/metrics.go
@@ -30,7 +30,7 @@ var (
 			Help:       "The time taken between a node's deletion request and the removal of its finalizer",
 			Objectives: metrics.SummaryObjectives(),
 		},
-		[]string{metrics.ProvisionerLabel},
+		[]string{metrics.ProvisionerLabel, metrics.NodePoolLabel},
 	)
 )