This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Restrict proofs table with UNIQUE(parent, prover)
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `Program`s are unique within `Workflow` and therefore it's impossible to have same `parent` and `prover` hashes for multiple proofs.
tuommaki
commented
Jan 12, 2024
| @@ -79,6 +79,7 @@ CREATE TABLE proof ( | |||
| parent VARCHAR(64) NOT NULL, | |||
| prover VARCHAR(64), | |||
| proof BYTEA NOT NULL, | |||
| UNIQUE(parent, prover), | |||
There was a problem hiding this comment.
Adding seat belts when discovering pitfalls 😬
There was a problem hiding this comment.
Yes, and I think it helps postgres to optimize the query.
musitdev
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Programs are unique withinWorkflowand therefore it's impossible to have sameparentandproverhashes for multiple proofs.