Suppress EPIPE and ECONNRESET tracebacks properly #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased it to include PY3 changes. |
|
I can benefit from this very much. I built a streaming audio application, and each time the client picks another number, the connection is abruptly closed, resulting in broken pipe errors. |
|
#445 too |
|
👍 |
5 similar comments
|
👍 |
|
👍 |
|
👍 |
|
👍 |
|
+1 |
This was referenced Dec 30, 2014
|
same problem for long polling after client (eg. browser) close, so +1 |
|
C'mon @gevent, what do you think? It's been a year. |
|
👍 |
1 similar comment
|
👍 |
|
👏✌️
|
|
🎉 Thanks for this! (It has been bugging me for years.) |
|
Happened to me on an SSE service with bottle. All is well now. ❤️ |
tilgovi
added a commit
to hypothesis/h
that referenced
this pull request
Sep 17, 2015
This should stop the logging that occurs when clients disconnect. gevent/gevent#377
tilgovi
added a commit
to hypothesis/h
that referenced
this pull request
Sep 17, 2015
This should stop the logging that occurs when clients disconnect. gevent/gevent#377
tilgovi
added a commit
to hypothesis/h
that referenced
this pull request
Sep 18, 2015
This should stop the logging that occurs when clients disconnect. gevent/gevent#377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception handler in
handle_one_response()was catching and dumping socket errors before the handler inhandler_one_request()ever got to see them and squash their tracebacks. So, I just moved the exception handler over tohandle_one_response.Fixes #136.