Add Checking and Force Flag for Directory in Serve Command #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
approved these changes
Aug 8, 2023
| @@ -81,6 +81,8 @@ web browser. | |||
|
|
|||
| Before starting, Zola will delete the output directory (by default `public` in project root) to start from a clean slate. | |||
|
|
|||
| If you are specifying the directory however using the `output-dir` flag, Zola will not use the specified directory if it already exists unless the --force flag is used. | |||
There was a problem hiding this comment.
could be just my English but wouldn't If you are however specifying the director using the output-dir flag be better?
There was a problem hiding this comment.
Randomly came across this while checking out Zola ... I'm throwing
If you are specifying the directory but are also using the `output-dir` flag, Zola will not use the specified directory if it already exists unless the --force flag is used.
in the ring.
| @@ -268,6 +269,12 @@ fn create_new_site( | |||
| site.enable_serve_mode(); | |||
| site.set_base_url(base_url); | |||
| if let Some(output_dir) = output_dir { | |||
| if !force && output_dir.exists() { | |||
There was a problem hiding this comment.
I would swap the 2 conditions just because it would be clearer imo
There was a problem hiding this comment.
This pattern honestly was taken straight from the build command's pattern of ifs.
Do you still think it's worth changing?
Keats
approved these changes
Aug 17, 2023
peterprototypes
pushed a commit
to peterprototypes/zola
that referenced
this pull request
Sep 12, 2023
Keats
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Introduce option to force directory when running the serve command * Update documentation about the force flag on the serve command * Resolve cargo fmt issue * Reword new serve flag documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #2251 by mimicking behavior of
buildcommand's checking of existing folders from the--output-dirflag, and also allows the use of a new--forceflag to override said directory for serving the files.IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: