Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting for Solidity, Vyper, and Cairo #1806

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

jakelang
Copy link

@jakelang jakelang commented Mar 20, 2022

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

Description

This pull request adds syntax highlighting support for three languages from the Ethereum ecosystem.

  • Solidity: The most popular language for writing Ethereum smart contracts
  • Vyper: An alternative, emerging language for Ethereum smart contracts.
  • Cairo: A language used to write contracts on StarkNet, an L2 scaling solution for Ethereum using STARKs.

All of the syntax files are sourced from https://github.com/davidhq/SublimeEthereum at the commit mentioned in sublime/syntaxes/extra/README.md. I did not add this repository as a submodule because I used Sublime to generate .sublime-syntax files for Vyper and Cairo from their respective .tmlanguage files.

The aforementioned repository appears to be well-maintained with changes made 3 days ago to support Solidity 0.8.13. Credit goes to the maintainers of this repository for the syntax files.

@Keats
Copy link
Collaborator

Keats commented Mar 21, 2022

Thanks for that. I'm actually going to holdd off adding more syntaxes until #1787 has been decided since I don't want to add something just to remove it.

@jakelang
Copy link
Author

@Keats any decision re: #1787?

@Keats
Copy link
Collaborator

Keats commented Apr 11, 2022

The decision is not planned soon, especially since you can easily load your own syntaxes/themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants