Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-1660: Organise Examples #140

Merged
merged 6 commits into from
Jul 20, 2020
Merged

SDK-1660: Organise Examples #140

merged 6 commits into from
Jul 20, 2020

Conversation

davidgrayston
Copy link
Contributor

@davidgrayston davidgrayston commented Jul 17, 2020 •
edited
Loading

Changed

  • Moved examples into _examples to keep them separate from main package
  • Each example now has its own go.mod file
  • Profile sandbox example tests no longer need to be renamed to run

@davidgrayston davidgrayston self-assigned this Jul 17, 2020
@davidgrayston davidgrayston requested a review from echarrod July 17, 2020 15:08
echarrod
echarrod reviewed Jul 17, 2020
View reviewed changes
_examples/aml/main.go Outdated Show resolved Hide resolved
@davidgrayston davidgrayston force-pushed the SDK-1660-organise-examples branch from e63ecec to 1a75600 Compare July 17, 2020 15:46
@davidgrayston davidgrayston requested a review from echarrod July 17, 2020 15:49
echarrod
echarrod reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@echarrod echarrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just had the question about module naming.

Also I was going to modify the pre-commit hook to do go mod tidy recursively, so we can modify all of these example modules too. Shall I commit to this PR?

_examples/aml/go.mod Show resolved Hide resolved
_examples/profile/go.mod Show resolved Hide resolved
_examples/profilesandbox/go.mod Show resolved Hide resolved
@echarrod
SDK-1660: Use sh file which runs go build ,.,, and go mod tidy re…
4474620 
…cursively, apply to _examples

Renamed tidy.sh -> goimports.sh, to avoid confusion with `go mod tidy`. Removed go build and go mod tidy steps from pre-commit, as these are covered by new script
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
1.1% 1.1% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

echarrod
echarrod approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@echarrod echarrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind if we either change the _examples module names, or leave as is

@davidgrayston davidgrayston merged commit 1262f43 into development Jul 20, 2020
@davidgrayston davidgrayston deleted the SDK-1660-organise-examples branch July 20, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarrod echarrod echarrod approved these changes

Assignees

@davidgrayston davidgrayston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgrayston @echarrod