Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] - Update mattermost to version v10.1.6 #1995

Closed
wants to merge 1 commit into from

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Dec 30, 2024

🤖 This is an automated pull request to update mattermost to version v10.1.6. This PR must be reviewed and tested before merging.

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ mattermost/docker-compose.yml External port mapping "8443:8443/tcp":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ mattermost/docker-compose.yml External port mapping "8443:8443/udp":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor Author

nmfretz commented Dec 30, 2024

🤖 This is an automated summary of installation tests for mattermost:

  • ✅ App successfully installed in umbrel-dev instance
  • ✅ App successfully listed in umbrel.yaml
  • ✅ App UI successfully returns a 200 status code
  • 📸 Screenshot of the app:
    App Screenshot

This PR must still be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Dec 31, 2024

@al-lac I ran mattermost through the auto-updater, but looks like we should probably refrain from doing this since they regularly release patch versions for past minor releases and tag as latest on github:
image

What do you think? Just keep this as a "manual" update for now (can still just run the auto-updater script with manual version input)? They have a very regular release schedule for minor/major version releases on the 16th of every month:

image

@nmfretz nmfretz changed the title Update mattermost to version v10.1.6 [DO NOT MERGE] - Update mattermost to version v10.1.6 Dec 31, 2024
@al-lac
Copy link
Contributor

al-lac commented Dec 31, 2024

Hey @nmfretz!

As I am maintaining the mattermost-docker repo, I will look into how to tackle this. Probably just need to adapt the github action logic for releasing.

Will look into it next week, happy new year! 🎆

@nmfretz
Copy link
Contributor Author

nmfretz commented Jan 2, 2025

Sounds good @al-lac! I'll also add a check in the auto-updater so that it won't attempt to update to a lower semver number.

Happy New Year!

@nmfretz nmfretz closed this Jan 2, 2025
@al-lac
Copy link
Contributor

al-lac commented Jan 7, 2025

Hey @nmfretz, I modified my release action so it should only set the highest release number as the latest release, see here: al-lac/mattermost-docker@0a2a5da

Also I think v10.1.6 was set as the latest release by mistake, seems they switched it back to v10.3.1 now as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants