Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update ibokuri dependency url #154

Merged
merged 1 commit into from
Feb 19, 2024
Merged

deps: Update ibokuri dependency url #154

merged 1 commit into from
Feb 19, 2024

Conversation

sea-grass
Copy link
Contributor

Rewrites the protest dependency url in build.zig.zon (doesn't change the dependency version). Fixes the following error seen on latest Zig master (0.12.0-dev.2811+3cafb9655):

getty/build.zig.zon:13:20: error: unable to unpack git files: BadZlibHeader
            .url = "git+https://github.com/ibokuri/protest.git#bae398b701e763ef18480aa3cfcca103716996de",
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

To reproduce the error:

  1. Add the latest Zig to your PATH
  2. Clear Zig caches (to ensure Zig build will attempt to fetch the protest dependency instead of using a cached version; there might be a better way to do this that doesn't involve nuking the entire cache): rm -rf ~/.cache/zig; cd path/to/getty; rm -rf zig-cache zig-out
  3. Run zig build
  4. See the above error

Fixes the following error seen on latest Zig master (`0.12.0-dev.2811+3cafb9655`):

```
.../build.zig.zon:13:20: error: unable to unpack git files: BadZlibHeader
```
@ibokuri ibokuri merged commit 165caba into getty-zig:main Feb 19, 2024
4 checks passed
@ibokuri
Copy link
Contributor

ibokuri commented Feb 19, 2024

Thanks for the patch!

@sea-grass sea-grass deleted the fix-dep-url branch February 19, 2024 19:02
Cloudef added a commit to Cloudef/zig2nix that referenced this pull request Feb 20, 2024
One of the deps failed the zig package manager
getty-zig/getty#154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants