builder: Don't use fakeroot #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebonrichie
force-pushed
the
drop-fakeroot
branch
5 times, most recently
from
9159a7d to
4764755
Compare
We're inside of a clean rootfs container, we can just build as root, using fakeroot is unnecessary.
Intended to replace ChrootExecStdin() in order to maintain more control over how we chroot in the environment.
joebonrichie
force-pushed
the
drop-fakeroot
branch
from
4764755 to
75ba95f
Compare
|
I've built a couple of packages with this (with the requisite ypkg version built and installed in my local repo). It appears to work. |
ermo
previously approved these changes
Sep 16, 2024
joebonrichie
force-pushed
the
drop-fakeroot
branch
from
75ba95f to
9343e6b
Compare
With ChrootShell() we can drop usage of the chroot binary, as well as choose the initial workdir to spawn in to. As the files are now build as root, they are owned by root so chroot as root but start at the buildUser home directory.
joebonrichie
force-pushed
the
drop-fakeroot
branch
from
9343e6b to
2a9786f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're inside of a clean rootfs container, we can just build as root, using fakeroot is unnecessary.
Depends on getsolus/ypkg#94
Closes #66