-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for embedded debug IDs in minified files #765
Conversation
|
#[derive(Deserialize)] | ||
struct DebugIdInSourceMap { | ||
debug_id: Option<DebugId>, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, haven't seen this trick before.
There is also this struct in |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
==========================================
+ Coverage 74.53% 74.68% +0.14%
==========================================
Files 70 71 +1
Lines 15317 15392 +75
==========================================
+ Hits 11417 11495 +78
+ Misses 3900 3897 -3 |
This adds support for parsing
debugId
references in the source file. It also provides utilities for parsing the comments separately so that code does not need to be written another time in other places.Followup to #762
Refs getsentry/sentry-cli#1469