fix(symcache): Fixed bug that caused functions to have len 0 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Classic |
jan-auer
approved these changes
Feb 15, 2021
| len, 0, | ||
| "While adding function {}: length must be positive", | ||
| function.name | ||
| ); | ||
|
|
||
| let len = match NonZeroU16::new(len) { | ||
| Some(len) => len, |
There was a problem hiding this comment.
Let's also break below, to avoid endless loops. Sorry about that, this was my mistake in the previous review suggestion.
jan-auer
added a commit
that referenced
this pull request
Mar 1, 2021
* master: test: add similar-asserts' assert_eq (#333) release: 8.0.4 meta: Changelog for 8.0.4 build: Drop support for python 2.7 (#328) meta(vscode): Fix include paths for C++ (#331) doc(debuginfo): Add descriptions of records to breakpad.pest (#329) build: Replace virtualenv with venv doc(symcache): Symcache documentation fix(debuginfo): Support debug_addr indexes in DWARF functions (#326) fix(symcache): Fixed bug that caused functions to have len 0 (#324) ref(symcache): FuncRecord::len must be nonzero (#323) fix: Clippy 1.50 lints (#322) fix(symcache): Support lookup for public syms larger than 65k (#320) fix(symcache): Compute correct line offsets (#319) release: 8.0.3 meta: Changelog build: Update goblin to 0.3.1 (#318) fix(elf): Consider sections of type SHT_MIPS_DWARF (#317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #285. The problem wast that in the line
symbolic/symbolic-symcache/src/writer.rs
Line 516 in c964bba
lencould be 0 ifend_address - start_addresswas a multiple of 2^16.