Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dotnet 4.2.1 #186

Merged
merged 2 commits into from
Mar 14, 2024
Merged

bump dotnet 4.2.1 #186

merged 2 commits into from
Mar 14, 2024

Conversation

bruno-garcia
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.88%. Comparing base (4327ca5) to head (8127074).

❗ Current head 8127074 differs from pull request most recent head 8b4b41e. Consider uploading reports for the commit 8b4b41e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   51.95%   51.88%   -0.07%     
==========================================
  Files          29       29              
  Lines        1461     1461              
  Branches      107      107              
==========================================
- Hits          759      758       -1     
- Misses        666      668       +2     
+ Partials       36       35       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bruno-garcia
Copy link
Member Author

bruno-garcia commented Mar 14, 2024

@bitsandfoxes was there a regression on the msbuild integration with sentry-cli to get the auth token via env var specifically on Windows? It passes on mac and linux

Env var is set SENTRY_AUTH_TOKEN

@bruno-garcia bruno-garcia merged commit 879aedb into main Mar 14, 2024
4 checks passed
@bruno-garcia bruno-garcia deleted the sentry/bump-dotnet branch March 14, 2024 13:12
@bitsandfoxes
Copy link
Contributor

It looks like we're hitting getsentry/sentry-cli#1951
And looking at the workflow:
We're adding the auth token explicitly for everything but Windows:

- name: Run batch build script
if: matrix.os == 'windows-latest'
shell: cmd
run: build.cmd
- name: Run bash build script
if: matrix.os != 'windows-latest'
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
run: ./build.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants