fix: Disable Profiling (#198)

getsentry · Jul 22, 2024 · 11979f6 · 11979f6
1 parent f50dfc4
commit 11979f6
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Various fixes & improvements
+
+- disable profiling (#198) by @bitsandfoxes
+
 ## 1.19.0
 
 ### Various fixes & improvements

diff --git a/src/Directory.Packages.props b/src/Directory.Packages.props
@@ -6,7 +6,6 @@
 
   <ItemGroup>
     <PackageVersion Include="Sentry.Extensions.Logging" Version="$(SentryVersion)" />
-    <PackageVersion Include="Sentry.Profiling" Version="$(SentryVersion)" />
     <PackageVersion Include="Sentry.AspNetCore" Version="$(SentryVersion)" />
     <PackageVersion Include="Sentry.Serilog" Version="$(SentryVersion)" />
     <PackageVersion Include="Google.Cloud.Storage.V1" Version="4.2.0" />

diff --git a/src/SymbolCollector.Console/Program.cs b/src/SymbolCollector.Console/Program.cs
@@ -4,7 +4,6 @@
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
 using Polly.Extensions.Http;
-using Sentry.Profiling;
 using Sentry.Protocol;
 using SymbolCollector.Core;
 using static System.Console;
@@ -231,11 +230,7 @@ private static void Bootstrap(Args args)
             o.AutoSessionTracking = true;
 
             o.TracesSampleRate = 1.0;
-            o.ProfilesSampleRate = 1.0;
-
-            o.AddIntegration(new ProfilingIntegration(
-                // Block up to 2 seconds to get profiling started before running the app
-                TimeSpan.FromSeconds(2)));
+            o.ProfilesSampleRate = 0.0;
 
             o.ExperimentalMetrics = new ExperimentalMetricsOptions
             {

diff --git a/src/SymbolCollector.Console/SymbolCollector.Console.csproj b/src/SymbolCollector.Console/SymbolCollector.Console.csproj
@@ -13,7 +13,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Sentry.Profiling" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
     <PackageReference Include="System.CommandLine.DragonFruit" />
   </ItemGroup>

diff --git a/src/SymbolCollector.Server/Program.cs b/src/SymbolCollector.Server/Program.cs
@@ -1,6 +1,4 @@
 using Microsoft.AspNetCore.Server.Kestrel.Core;
-using Sentry;
-using Sentry.Profiling;
 using Serilog;
 using SystemEnvironment = System.Environment;
 
@@ -73,10 +71,6 @@ private static IHostBuilder CreateHostBuilder(string[] args) =>
                 {
                     o.Dsn = "https://[email protected]/1886021";
 
-                    o.AddIntegration(new ProfilingIntegration(
-                        // Block up to 2 seconds to get profiling started before running the app
-                        TimeSpan.FromSeconds(2)));
-
                     // o.ExperimentalMetrics = new ExperimentalMetricsOptions
                     // {
                     //     EnableCodeLocations = true,

diff --git a/src/SymbolCollector.Server/SymbolCollector.Server.csproj b/src/SymbolCollector.Server/SymbolCollector.Server.csproj
@@ -9,7 +9,6 @@
   <ItemGroup>
     <PackageReference Include="Sentry.AspNetCore" />
     <PackageReference Include="Sentry.Serilog" />
-    <PackageReference Include="Sentry.Profiling" />
     <PackageReference Include="Google.Cloud.Storage.V1" />
     <PackageReference Include="Serilog.AspNetCore" />
     <PackageReference Include="Serilog.Settings.Configuration" />

diff --git a/src/SymbolCollector.Server/appsettings.Development.json b/src/SymbolCollector.Server/appsettings.Development.json
@@ -6,7 +6,7 @@
   },
   "Sentry": {
     "TracesSampleRate": 1.0,
-    "ProfilesSampleRate": 1.0
+    "ProfilesSampleRate": 0.0
   },
   "GoogleCloud": {
     "JsonCredentialParameters": {

diff --git a/src/SymbolCollector.Server/appsettings.json b/src/SymbolCollector.Server/appsettings.json
@@ -26,7 +26,7 @@
     "DiagnosticLevel": "Info",
     "Dsn": "https://[email protected]/1886021",
     "TracesSampleRate": 1.0,
-    "ProfilesSampleRate": 0.25,
+    "ProfilesSampleRate": 0.0,
     "DefaultTags": {
       "app": "SymbolCollector.Server"
     }