Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(smart_autocomplete): remove smart autocomplete mv #6867

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

volokluev
Copy link
Member

  • Takes up too much space
  • full table scan if the attribute doesn't exist

@volokluev volokluev requested review from a team as code owners February 10, 2025 18:31
Copy link

This PR has a migration; here is the generated SQL for ./snuba/migrations/groups.py ()

-- start migrations

-- forward migration events_analytics_platform : 0024_remove_smart_autocomplete_values_mv
Local op: DROP TABLE IF EXISTS eap_trace_item_attrs_mv;
Local op: DROP TABLE IF EXISTS eap_trace_item_attrs_local;
Distributed op: DROP TABLE IF EXISTS eap_trace_item_attrs_dist;
-- end forward migration events_analytics_platform : 0024_remove_smart_autocomplete_values_mv




-- backward migration events_analytics_platform : 0024_remove_smart_autocomplete_values_mv
-- end backward migration events_analytics_platform : 0024_remove_smart_autocomplete_values_mv

@volokluev volokluev enabled auto-merge (squash) February 10, 2025 18:43
@volokluev volokluev merged commit 34e78bb into master Feb 10, 2025
32 checks passed
@volokluev volokluev deleted the volo/remove_smart_autocomplete_mv branch February 10, 2025 18:58
@getsentry-bot
Copy link
Contributor

PR reverted: 0bdf9a9

getsentry-bot added a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants