Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INC: Turn off DLQ for search issues/generic events #6819

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Jan 24, 2025

turn off temporarily

@ayirr7 ayirr7 requested review from a team as code owners January 24, 2025 19:04
@ayirr7 ayirr7 changed the title INC: Turn off DLQ INC: Turn off DLQ for search issues generic events Jan 24, 2025
@ayirr7 ayirr7 changed the title INC: Turn off DLQ for search issues generic events INC: Turn off DLQ for search issues/generic events Jan 24, 2025
@volokluev volokluev merged commit d125cf2 into master Jan 24, 2025
28 of 31 checks passed
@volokluev volokluev deleted the riya/turn-off-DLQ branch January 24, 2025 19:14
Copy link

codecov bot commented Jan 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
591 1 590 2
View the top 1 failed tests by shortest run time
tests.admin.dead_letter_queue.test_dlq::test_dlq
Stack Traces | 0.003s run time
Traceback (most recent call last):
  File ".../admin/dead_letter_queue/test_dlq.py", line 5, in test_dlq
    assert len(get_dlq_topics()) == 9
AssertionError: assert 8 == 9
 +  where 8 = len([{'logicalName': 'snuba-dead-letter-querylog', 'physicalName': 'snuba-dead-letter-querylog', 'slice': None, 'storage': 'querylog'}, {'logicalName': 'snuba-dead-letter-group-attributes', 'physicalName': 'snuba-dead-letter-group-attributes', 'slice': None, 'storage': 'group_attributes'}, {'logicalName': 'snuba-dead-letter-replays', 'physicalName': 'snuba-dead-letter-replays', 'slice': None, 'storage': 'replays'}, {'logicalName': 'snuba-dead-letter-generic-metrics', 'physicalName': 'snuba-dead-letter-generic-metrics', 'slice': None, 'storage': 'generic_metrics_sets_raw'}, {'logicalName': 'snuba-dead-letter-generic-metrics', 'physicalName': 'snuba-dead-letter-generic-metrics', 'slice': None, 'storage': 'generic_metrics_gauges_raw'}, {'logicalName': 'snuba-dead-letter-generic-metrics', 'physicalName': 'snuba-dead-letter-generic-metrics', 'slice': None, 'storage': 'generic_metrics_counters_raw'}, ...])
 +    where [{'logicalName': 'snuba-dead-letter-querylog', 'physicalName': 'snuba-dead-letter-querylog', 'slice': None, 'storage': 'querylog'}, {'logicalName': 'snuba-dead-letter-group-attributes', 'physicalName': 'snuba-dead-letter-group-attributes', 'slice': None, 'storage': 'group_attributes'}, {'logicalName': 'snuba-dead-letter-replays', 'physicalName': 'snuba-dead-letter-replays', 'slice': None, 'storage': 'replays'}, {'logicalName': 'snuba-dead-letter-generic-metrics', 'physicalName': 'snuba-dead-letter-generic-metrics', 'slice': None, 'storage': 'generic_metrics_sets_raw'}, {'logicalName': 'snuba-dead-letter-generic-metrics', 'physicalName': 'snuba-dead-letter-generic-metrics', 'slice': None, 'storage': 'generic_metrics_gauges_raw'}, {'logicalName': 'snuba-dead-letter-generic-metrics', 'physicalName': 'snuba-dead-letter-generic-metrics', 'slice': None, 'storage': 'generic_metrics_counters_raw'}, ...] = get_dlq_topics()

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@getsentry-bot
Copy link
Contributor

PR reverted: 07d135c

getsentry-bot added a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants