ref(lw-deletes): add project_id killswitch and some logging #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeredithAnya
commented
Dec 13, 2024
| @@ -94,7 +94,6 @@ delete_allocation_policies: | |||
| args: | |||
| required_tenant_types: | |||
| - referrer | |||
| - project_id | |||
There was a problem hiding this comment.
This is intentional - now that we have the batching approach, the allocation policy won't have a project_id because it will be (potentially) multiple project_ids, so we can ratelimit based on that. This allocation policy will work similar to the subscriptions executor where there is one referrer for those queries.
MeredithAnya
commented
Dec 13, 2024
|
|
||
| self.__next_step.submit(message) | ||
|
|
||
| def _get_attribute_info(self) -> AttributionInfo: | ||
| return AttributionInfo( | ||
| app_id=AppID("lw-deletes"), | ||
| tenant_ids={}, | ||
| referrer="lw-deletes", | ||
| referrer=f"lw-deletes-{self.__storage_name}", |
There was a problem hiding this comment.
There are no tenant ids passed from the batch of messages, just the referrer which I've added to be by storage so that we can change the allocation policy per storage
There was a problem hiding this comment.
Although now that I think about it, the policy is defined on the storage... so this might just be redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple improvements and additions to the lw delete pipeline, the main one being the killswitch for the project.
Most storages should have the
project_idas one of the allowed columns so the assumption right now is that they do and so the killswitch will work for that case. If we add more storages in the future that don't have that, we can update the killswitch logic. The config will be based on the storage:lw_deletes_killswitch_search_issuesThe killswitch is added at the API level because the moment it's produced to the consumer it's batched with other messages, most likely with other
project_id's. Another option would be to add another strategy step prior to the batch step that filters based on the killswitch, but I felt like not producing to the topic at all made more sense right now.