Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devservices): Add healthchecks to clickhouse and snuba #6616

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Dec 4, 2024

This adds healthchecks to clickhouse and snuba for devservices. This is required because we want devservices to properly understand when a container is healthy/unhealthy to help developers out when encountering issues with their local dev environment.

@hubertdeng123 hubertdeng123 requested a review from a team as a code owner December 4, 2024 23:40
Copy link
Member

@onkar onkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please add some justification in the PR description on why is this required?

@hubertdeng123
Copy link
Member Author

Can you please add some justification in the PR description on why is this required?
Done

@hubertdeng123 hubertdeng123 merged commit e96cb82 into master Dec 6, 2024
30 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-healthchecks-devservices branch December 6, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants