feat(eap-api): Use signs in count, average, and sum calculations #6613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
approved these changes
Dec 4, 2024
|
What is the motivation behind this PR? |
We are using a ReplacingMergeTree which stores a sign representing whether a row was added or deleted. In order to compute counts, sums, and averages correctly we need to account for the sign in the calculation. |
|
@davidtsuk should we add unit tests covering the sign representation? |
We aren't actually using negative signs yet, so we can't add any tests yet for that. Since the existing tests pass, I think it's okay to wait until we start using negative signs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getsentry/eap-planning/issues/105