Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hierarchical hashes from code base #6604

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Remove hierarchical hashes from code base #6604

merged 5 commits into from
Dec 3, 2024

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Nov 26, 2024 •
edited
Loading

Hierarchical grouping was deprecated back in September.

See project: https://github.com/orgs/getsentry/projects/242

The failing test depends on this PR getting merged first: getsentry/sentry-kafka-schemas#353

@armenzg
Remove hierarchical hashes from code base
9432f07 
Hierarchical grouping was deprecated back in September.

See project: https://github.com/orgs/getsentry/projects/242
@armenzg armenzg requested a review from a team as a code owner November 26, 2024 16:47
untitaker
untitaker approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, assuming that CI passes, this can be rolled out. However, we should follow up with a migration to remove this col from prod, eventually.

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
756 1 755 3
View the top 1 failed tests by shortest run time 
tests.consumers.test_message_processors::test_message_processors[events-ErrorsProcessor]
Stack Traces | 0.012s run time 
Traceback (most recent call last):
  File ".../tests/consumers/test_message_processors.py", line 66, in test_message_processors
    python_processed_message = processor().process_message(
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../datasets/processors/errors_processor.py", line 94, in process_message
    raise InvalidMessageType(f"Invalid message type: {type_}")
snuba.processor.InvalidMessageType: Invalid message type: end_unmerge_hierarchical

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@armenzg armenzg mentioned this pull request Nov 26, 2024
Merged
@armenzg armenzg self-assigned this Nov 26, 2024
@armenzg armenzg enabled auto-merge (squash) December 3, 2024 12:43
This was referenced Dec 3, 2024
Closed
Merged
Merged
armenzg added a commit to getsentry/relay that referenced this pull request Dec 3, 2024
@armenzg
chore: Upgrade sentry-kafka-schemas (#4327)
556f6b6 
This is to include [this
change](getsentry/sentry-kafka-schemas#353) and
to unblock [this Snuba
PR](getsentry/snuba#6604).

#skip-changelog
@armenzg armenzg disabled auto-merge December 3, 2024 14:14
armenzg added a commit to getsentry/sentry that referenced this pull request Dec 3, 2024
@armenzg @getsantry
chore: Upgrade sentry-kafka-schemas (#81573)
a805641 
This is to include [this
change](getsentry/sentry-kafka-schemas#353) and
to unblock [this Snuba
PR](getsentry/snuba#6604).

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@armenzg armenzg merged commit db53174 into master Dec 3, 2024
31 checks passed
@armenzg armenzg deleted the remove_hierarchical_hashes/armenzg branch December 3, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@armenzg armenzg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armenzg @untitaker