-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CapMan visibility] add throttling to BytesScannedRejectingPolicy #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xurui-c
force-pushed
the
rachel/throttleBytesScannedRejectingPolicy
branch
from
June 12, 2024 18:25
38d30c0
to
832278a
Compare
volokluev
approved these changes
Jun 12, 2024
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 2459 tests with View the full list of failed tests
|
xurui-c
force-pushed
the
rachel/throttleBytesScannedRejectingPolicy
branch
from
June 12, 2024 19:07
832278a
to
d950a87
Compare
xurui-c
changed the title
[CapMan] add throttling to BytesScannedRejectingPolicy
[CapMan visibility] add throttling to BytesScannedRejectingPolicy
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getsentry.atlassian.net/browse/SNS-2794
The BytesScannedRejectingPolicy prevents a (project_id|organization_id, referrer) combination from sending too many queries by rejecting them once such combination reaches a rejection threshold. I add a throttle threshold so the offending combination will get throttled first before getting rejected. BytesScannedRejectingPolicy will half the threads when the number of bytes scanned goes over 50% of the rejection threshold for that combination.
Roll out plan:
In this PR, I set the throttle dividers to 1 so that the rejection threshold and the throttle threshold are the same, so effectively this PR will create the options on Snuba Admin without doing any throttling. Then, within S4S, I will adjust the throttle dividers. With this, I expect to see queries being throttled in DD under the metric concurrent_queries_throttled. I will change the throttle dividers to 0.5 afterwards.