Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue summary) Only show possible cause if confident and novel #84339

Closed

Conversation

kddubey
Copy link

@kddubey kddubey commented Jan 30, 2025

possible_cause_confidence increases when there's less speculation (which correlates w/ slightly more accurate causes)

possible_cause_novelty increases when there's more novelty / less redundancy wrt whats_wrong

thresholds led to 50% of possible causes getting dropped on our autofix sentry issues (notebook here)

tested that this change is independent of the backend one by running sentry + seer on main and then on this branch. manually tested the threshold is respected by hardcoding the novelty score to 1 in seer locally

@kddubey kddubey requested a review from roaga January 30, 2025 21:22
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jan 30, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@kddubey
Copy link
Author

kddubey commented Jan 30, 2025

whoops gonna separate changes

@kddubey kddubey closed this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
32322 3 32319 295
View the top 3 failed tests by shortest run time
GroupSummary shows loading state
Stack Traces | 0.022s run time
Error: expect(received).toHaveLength(expected)

Expected length: 2
Received length: 1
Received array:  [<div class="css-11jfphb-Placeholder e2q81od0" data-test-id="loading-placeholder" />]
    at Object.<anonymous> (.../components/group/groupSummary.spec.tsx:86:79)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
SolutionsSection renders loading state when summary is pending
Stack Traces | 0.054s run time
Error: expect(received).toHaveLength(expected)

Expected length: 3
Received length: 2
Received array:  [<div class="css-11jfphb-Placeholder e2q81od0" data-test-id="loading-placeholder" />, <div class="css-1o36ccl-Placeholder-ButtonPlaceholder e16xethm0" data-test-id="loading-placeholder" />]
    at Object.<anonymous> (.../streamline/sidebar/solutionsSection.spec.tsx:191:79)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
Performance > VitalDetail applies conditions when linking to transaction summary
Stack Traces | 0.485s run time
TestingLibraryElementError: Unable to find a label with the text of: See transaction summary of the transaction something

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at getAllByLabelText (.../sentry/sentry/node_modules/@.../dist/queries/label-text.js:111:38)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../performance/vitalDetail/index.spec.tsx:269:76)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@kddubey kddubey deleted the kddubey/issue-summary/thresholds-possible-cause branch January 30, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant