chore(issue-details): Variety of small fixes #84273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
snigdhas
approved these changes
Jan 29, 2025
| @@ -45,6 +46,7 @@ const BASE_CONFIG: IssueTypeConfig = { | |||
| resolution: t('Resolved'), | |||
| eventUnits: t('Events'), | |||
| }, | |||
| allEventsPath: Tab.EVENTS, | |||
scttcper
approved these changes
Jan 29, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
Pulled out some changes from a separate PR to put together the 'All Check-ins' page, hopefully making that PR a bit easier to review whenever it's ready to put up. Things in this PR: - Add the 'all events path' directly to the issue config. The only issue that changes this is currently metric issues, but uptime and crons will change this in my other PR. - Omit the discover button on non-All Events pages. If the tab is not All Events, the discover query will not match the data in the table, so the button should be omitted - Fixes the links for uptime monitors, which I incorrectly thought matched metric alerts. - Adds links for cron monitors to the sidebar for cron issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out some changes from a separate PR to put together the 'All Check-ins' page, hopefully making that PR a bit easier to review whenever it's ready to put up.
Things in this PR: