fix(insights): remove extra filters when navigating to transaction summary #84270
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
gggritso
approved these changes
Jan 30, 2025
bcoe
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #82661
Each overview page has a select set of filters applied to it, for example the frontend overview page applies filters
(transaction.op:pageload OR transaction.op:navigation OR transaction.op:ui.render OR transaction.op:interaction.Currently when you click on a transaction on the overview page you end up at the transaction summary page, because those filters are applied to the eventView, they end up at the transaction summary page too.
This creates an ugly experience, and it actually does something that user does not expect. Because the overviewpage table includes
transaction.opas a column, we would expect that the row that they clicked, has the corresponding transaction op applied.For example, clicking on this row, we would expect the filter to be
transaction.op:navigationonlyThis PR updates the table so that if a transaction.op exists on the row, when you click on the transaction only that op will be applied.
I.e with the previous screenshot, we now end up with
