ref: default result_type= to "numeric" #84268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
IanWoodard
approved these changes
Jan 29, 2025
constantinius
approved these changes
Jan 30, 2025
shellmayr
reviewed
Jan 30, 2025
| @@ -950,7 +950,6 @@ class SingularEntityDerivedMetric(DerivedMetricExpression): | |||
|
|
|||
There was a problem hiding this comment.
If we're getting rid of the init override, the entire if not TYPE_CHECKING conditional here along with the comment could be eliminated as well.
There was a problem hiding this comment.
there's other behaviour in the __init__ though
shellmayr
approved these changes
Jan 30, 2025
snigdhas
pushed a commit
that referenced
this pull request
Jan 30, 2025
the nullability makes the type system rather angry with this class <!-- Describe your PR here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the nullability makes the type system rather angry with this class