-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(aci): invoke the correct legacy registry from the notification action #84245
Open
iamrajjoshi
wants to merge
5
commits into
master
Choose a base branch
from
raj/noa/invoke-correct-legacy-registry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+124
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Jan 29, 2025
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
iamrajjoshi
commented
Jan 29, 2025
from tests.sentry.workflow_engine.test_base import BaseWorkflowTest | ||
|
||
|
||
class TestNotificationActionHandler(BaseWorkflowTest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need test to ensure group_type exists since
def enforce_config_schema(sender, instance: Detector, **kwargs): |
GabeVillalobos
approved these changes
Jan 29, 2025
tests/sentry/workflow_engine/handlers/action/test_notification_action.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need the notification action to invoke the existing registries (issue alert or metric alert). we can do this by look at the detector type, since it is mapped to the grouptype slug
sentry/src/sentry/workflow_engine/models/detector.py
Lines 57 to 58 in 3eca9de
so what we do is register each of the individual functions
invoke_metric_alert_registry
andinvoke_issue_alert_registry
to grouptype, so we can look at the detector type to invoke the correct function.might be easier to review via https://github.com/getsentry/sentry/blob/raj/noa/invoke-correct-legacy-registry/src/sentry/workflow_engine/handlers/action/notification.py
https://www.notion.so/sentry/Alerts-Create-Issues-Notification-Action-NOA-1268b10e4b5d805b967ed2655c962db6#1268b10e4b5d812aaa59e13c96a04abd