Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike(aci): delayed processing for workflows #84238

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cathteng
Copy link
Member

beep boop

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23675 1 23674 292
View the top 1 failed tests by shortest run time
tests.sentry.test_devimports::test_startup_imports[sentry]
Stack Traces | 36.5s run time
#x1B[1m#x1B[31mtests/sentry/test_devimports.py#x1B[0m:111: in test_startup_imports
    validate_package(pkg, EXCLUDED, XFAIL)
#x1B[1m#x1B[31mtests/sentry/test_devimports.py#x1B[0m:106: in validate_package
    raise AssertionError(ret.stdout)
#x1B[1m#x1B[31mE   AssertionError: <string>:15: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa..../en/latest/pkg_resources.html#x1B[0m
#x1B[1m#x1B[31mE     return orig(name, globals=globals, locals=locals, fromlist=fromlist, level=level)#x1B[0m
#x1B[1m#x1B[31mE   error importing sentry.workflow_engine.processors.delayed_workflow:#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Traceback (most recent call last):#x1B[0m
#x1B[1m#x1B[31mE     File "<string>", line 35, in <module>#x1B[0m
#x1B[1m#x1B[31mE       __import__(name)#x1B[0m
#x1B[1m#x1B[31mE       ~~~~~~~~~~^^^^^^#x1B[0m
#x1B[1m#x1B[31mE     File "<string>", line 15, in _import#x1B[0m
#x1B[1m#x1B[31mE       return orig(name, globals=globals, locals=locals, fromlist=fromlist, level=level)#x1B[0m
#x1B[1m#x1B[31mE     File ".../workflow_engine/processors/delayed_workflow.py", line 50, in <module>#x1B[0m
#x1B[1m#x1B[31mE       from sentry.workflow_engine.types import Workflow, WorkflowJob#x1B[0m
#x1B[1m#x1B[31mE   ImportError: cannot import name 'Workflow' from 'sentry.workflow_engine.types' (.../sentry/workflow_engine/types.py)#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Base automatically changed from cathy/aci/delayed-processing-setup to master January 30, 2025 18:41
Comment on lines +318 to +319
filtered_actions.extend(list(evaluate_workflow_action_filters(workflows, job)))
filtered_actions.extend(list(get_filtered_actions(group_IF_dcgs, job)))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: figure out what to do if there are WHEN dcgs with slow conditions are connected to IF dcgs with slow conditions 😵‍💫

with sentry_sdk.start_span(op="workflow_engine.process_workflows.trigger_actions"):
for action in filtered_actions:
action.trigger(job, detector)

Copy link
Member Author

@cathteng cathteng Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remember to update ActionGroupStatus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant