-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spike(aci): delayed processing for workflows #84238
base: master
Are you sure you want to change the base?
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
filtered_actions.extend(list(evaluate_workflow_action_filters(workflows, job))) | ||
filtered_actions.extend(list(get_filtered_actions(group_IF_dcgs, job))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: figure out what to do if there are WHEN dcgs with slow conditions are connected to IF dcgs with slow conditions 😵💫
with sentry_sdk.start_span(op="workflow_engine.process_workflows.trigger_actions"): | ||
for action in filtered_actions: | ||
action.trigger(job, detector) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remember to update ActionGroupStatus
beep boop