ref(issue-views): Fix query count animation #83624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
MichaelSun48
changed the title
malwilley
approved these changes
Jan 17, 2025
scttcper
reviewed
Jan 17, 2025
| } else if (isError) { | ||
| setCount(0); | ||
| } | ||
| }, [queryCount, isFetching, isError, view.query, view.unsavedChanges]); |
There was a problem hiding this comment.
you might just want a useMemoWithPrevious here
There was a problem hiding this comment.
About to push a commit that does the same thing but with no hooks (and just some hackiness), detailed here
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
MichaelSun48
force-pushed
the
msun/issueViews/useStateAndEffectForCountsAgain
branch
from
7793e20 to
ede7678
Compare
MichaelSun48
deleted the
msun/issueViews/useStateAndEffectForCountsAgain
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
~Reverts the latest commit in [this PR](#83515) by adding back the use of and effect and state to achieve the desired animation behavior for issue counts.~ Implements the query count animation in a way that achieves the desired behavior without using state and effect [Relevant discussion](#82990 (comment)) This is currently in prod: https://github.com/user-attachments/assets/6c64d85c-6e39-41a5-b11e-6ceeaafa76e7 When you change the search query (not the page filters), the bubble flashes to 0 and shrinks before resizing once the response comes in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the latest commit in this PR by adding back the use of and effect and state to achieve the desired animation behavior for issue counts.Implements the query count animation in a way that achieves the desired behavior without using state and effect
Relevant discussion
This is currently in prod:
Screen.Recording.2025-01-16.at.2.56.13.PM.mov
When you change the search query (not the page filters), the bubble flashes to 0 and shrinks before resizing once the response comes in.