Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(workflow_engine): Remove DetectorType #82111

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

saponifi3d
Copy link
Contributor

Description

Removes the DetectorType from the workflow_engine.type and adds comments to clarify how this type is defined and used.

@saponifi3d saponifi3d requested a review from a team December 13, 2024 23:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 13, 2024
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice comments

@saponifi3d saponifi3d force-pushed the jcallender/aci/delete-detector-type branch from 05b46a5 to 93b5eb2 Compare December 13, 2024 23:08
@saponifi3d saponifi3d changed the base branch from jcallender/aci/process_data_packets to master December 13, 2024 23:08
…clearer what's linking here and why it's not more explicit
@saponifi3d saponifi3d force-pushed the jcallender/aci/delete-detector-type branch from 93b5eb2 to bf552ec Compare December 13, 2024 23:10
@saponifi3d saponifi3d enabled auto-merge (squash) December 13, 2024 23:28
@saponifi3d saponifi3d merged commit d1e9d20 into master Dec 13, 2024
47 checks passed
@saponifi3d saponifi3d deleted the jcallender/aci/delete-detector-type branch December 13, 2024 23:38
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82111      +/-   ##
==========================================
- Coverage   80.37%   72.48%   -7.89%     
==========================================
  Files        7276     7276              
  Lines      321471   321475       +4     
  Branches    20966    20966              
==========================================
- Hits       258367   233008   -25359     
- Misses      62696    87247   +24551     
- Partials      408     1220     +812     

@saponifi3d saponifi3d restored the jcallender/aci/delete-detector-type branch December 14, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants