ref(replay): improve error messages for invalid searches that raise CouldNotParseValue #82048
+50
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouldNotParseValue
github-actions
bot
added
the
Scope: Backend
michellewzhang
approved these changes
Dec 12, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #82048 +/- ##
==========================================
+ Coverage 80.36% 80.38% +0.01%
==========================================
Files 7275 7273 -2
Lines 321407 321204 -203
Branches 20962 20931 -31
==========================================
- Hits 258298 258199 -99
+ Misses 62698 62593 -105
- Partials 411 412 +1 |
cmanallen
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80574
CouldNotParseValue is a custom error we raise in parsers.py. They contain messages useful for users, but we need to include it in this exc handler first.
Also adds the parsed value to the msg
Relates to