fix(platforms): Split up between cloudflare pages and workers #77774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
Lms24 and
andreiborza
and removed request for
a team
github-actions
bot
added
the
Scope: Backend
priscilawebdev
approved these changes
Sep 23, 2024
Lms24
approved these changes
Sep 23, 2024
yup will do that next! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #77769 I added the cloudflare sdk as a new platform for onboarding docs.
This PR builds on top of that by reverting the change to add
javascript-cloudflareas a platform and instead have two platforms for cloudflare workers and cloudflare pages (given they have completely different setup instructions and use cases).In our docs pages and workers have two different configure paths: https://docs.sentry.io/platforms/javascript/guides/cloudflare/#configure