ref: remove OrganizationAbsoluteUrlMixin #75360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
joshuarli
approved these changes
Jul 31, 2024
asottile-sentry
deleted the
asottile-remove-organization-absolute-url-mixin
branch
asottile-sentry
added a commit
that referenced
this pull request
Jul 31, 2024
<!-- Describe your PR here. --> this had three sets of breakage addressed by other PRs: - our foreign key subclass was not functioning, django-stubs added a default TypeVar here which started getting filled in with an unbound TypeVar resulting in thousands of errors: fixed by #75228 - we were able to remove our fork's [descriptor patch](getsentry/sentry-forked-django-stubs#4) (which removed the non-model overload of `__get__` for fields) as mypy [fixed this issue](python/mypy#17381). in doing so it pointed out an unsafe descriptor access through a mixin and so that had to go: #75360 - django-stubs improved some field validation through QuerySets which was only checked through managers before: fixed by #75359
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocker for upgrading to django-stubs 5.0.4