Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): allow wildcards in metrics search bar #74332

Merged

Conversation

shellmayr
Copy link
Member

Wildcards were previously dis-allowed in #69644 due to #69387
With getsentry/snuba#5972 being merged, wildcards now work and can be re-allowed in the UI

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Bundle Report

Changes will decrease total bundle size by 20 bytes ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 27.93MB 20 bytes ⬇️

@shellmayr shellmayr marked this pull request as ready for review July 16, 2024 07:01
@shellmayr shellmayr requested a review from a team as a code owner July 16, 2024 07:01
@shellmayr shellmayr requested a review from ArthurKnaus July 16, 2024 07:01
@@ -129,7 +129,6 @@ export function MetricSearchBar({
placeholder={t('Filter by tags')}
query={query}
savedSearchType={SavedSearchType.METRIC}
disallowWildcard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check: This component is also used in alerts, where we use the event-stats endpoint.
Will is work also there?

@shellmayr shellmayr merged commit 6620d36 into master Jul 16, 2024
43 of 44 checks passed
@shellmayr shellmayr deleted the shellmayr/feat/re-allow-wildcards-in-metrics-search branch July 16, 2024 07:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants