Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Update Loader Script UI to accomodate v8 #73836

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat(ui): Update Loader Script UI to accomodate v8 #73836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4796600
feat(ui): Update Loader Script UI to accomodate v8
mydea Jul 4, 2024
3c87a80
small fixes
mydea Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions static/app/views/settings/project/projectKeys/details/loaderSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,16 @@ export function LoaderSettings({keyId, orgSlug, project, data, updateData}: Prop
? t('Only available in SDK version 7.x and above')
: data.dynamicSdkLoaderOptions.hasReplay
? tct(
'When using Replay, the loader will load the ES6 bundle instead of the ES5 bundle. The default configurations are [codeReplay:replaysSessionSampleRate: 0.1] and [codeError:replaysOnErrorSampleRate: 1]. [configDocs:Read the docs] to learn how to configure this.',
`[es5Warning]The default configurations are [codeReplay:replaysSessionSampleRate: 0.1] and [codeError:replaysOnErrorSampleRate: 1]. [configDocs:Read the docs] to learn how to configure this.`,
{
es5Warning:
// latest is deprecated but resolves to v7
data.browserSdkVersion === '7.x' ||
data.browserSdkVersion === 'latest'
? t(
'When using Replay, the loader will load the ES6 bundle instead of the ES5 bundle.'
) + ' '
: '',
codeReplay: <code />,
codeError: <code />,
configDocs: (
Expand Down Expand Up @@ -265,5 +273,5 @@ export function LoaderSettings({keyId, orgSlug, project, data, updateData}: Prop
}

function sdkVersionSupportsPerformanceAndReplay(sdkVersion: string): boolean {
return sdkVersion === 'latest' || sdkVersion === '7.x';
return sdkVersion === 'latest' || sdkVersion === '7.x' || sdkVersion === '8.x';
}
Loading