Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to select v8 in Loader Script #73835

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: Allow to select v8 in Loader Script #73835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ def register_temporary_features(manager: FeatureManager):
# Enable the new issue stream search bar UI
manager.add("organizations:issue-stream-search-query-builder", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
manager.add("organizations:large-debug-files", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
# Enable v8 support for the Loader Script
manager.add("organizations:js-sdk-loader-v8", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
# Enabled latest adopted release filter for issue alerts
manager.add("organizations:latest-adopted-release-filter", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
manager.add("organizations:mep-rollout-flag", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
Expand Down
11 changes: 8 additions & 3 deletions src/sentry/loader/browsersdkversion.py
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change line 73 in this file? It think is not giving back v8.

Copy link
Member

@lforst lforst Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is by design :) We don't want to put people who are currently on latest (7.x), on 8.x because that may break them.

Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from packaging.version import Version

import sentry
from sentry import features

logger = logging.getLogger("sentry")

Expand Down Expand Up @@ -37,8 +38,7 @@ def get_highest_browser_sdk_version(versions):


def get_all_browser_sdk_version_versions():
# todo: v8 add version
return ["latest", "7.x", "6.x", "5.x", "4.x"]
return ["latest", "8.x", "7.x", "6.x", "5.x", "4.x"]


def get_all_browser_sdk_version_choices():
Expand Down Expand Up @@ -98,4 +98,9 @@ def get_default_sdk_version_for_project(project):


def get_available_sdk_versions_for_project(project):
return project.get_option("sentry:loader_available_sdk_versions")
versions = project.get_option("sentry:loader_available_sdk_versions")

if features.has("organizations:js-sdk-loader-v8", project.organization, actor=None):
return versions + ["8.x"]

return versions
Loading