feat(feedback onboarding): add angular, astro, ember docs #65662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
reviewed
Feb 22, 2024
| { | ||
| type: StepType.INSTALL, | ||
| description: tct( | ||
| 'For the User Feedback integration to work, you must have the Sentry browser SDK package, or an equivalent framework SDK (e.g. [code:@sentry/react]) installed, minimum version 7.85.0.', |
There was a problem hiding this comment.
Suggested change
| 'For the User Feedback integration to work, you must have the Sentry browser SDK package, or an equivalent framework SDK (e.g. [code:@sentry/react]) installed, minimum version 7.85.0.', | |
| 'For the User Feedback integration to work, you must have the Sentry browser SDK package, or an equivalent framework SDK (e.g. [code:@sentry/angular]) installed, minimum version 7.85.0.', |
There was a problem hiding this comment.
could also be [codeAngular:@sentry/angular] or [codeIvy:@sentry/angular-ivy] as the replay snippet above
There was a problem hiding this comment.
or we could rephrase this sentence... i don't have a strong suggestion for that though, just an option. I was looking at how it's phrased for the react onboarding and it's a bit different, which is fine to be the same or different too.
There was a problem hiding this comment.
i'm copying how it's phrased in the docs, but will incorporate the first suggestion for sure
ryan953
reviewed
Feb 22, 2024
ryan953
reviewed
Feb 22, 2024
ryan953
approved these changes
Feb 22, 2024
michellewzhang
force-pushed
the
mz/onb-1
branch
from
5bc391d to
1a1c4f6
Compare
michellewzhang
force-pushed
the
mz/onb-1
branch
from
1a1c4f6 to
3f3692f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Angular, Astro, and Ember onboarding docs for user feedback
Relates to #62792