Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(devserver): Remove legacy https support #60734

Merged

Conversation

evanpurkhiser
Copy link
Member

After #60673 we're doing https
proxying via the webpack devserver.

After #60673 we're doing https
proxying via the webpack devserver.
@evanpurkhiser evanpurkhiser requested a review from a team November 28, 2023 23:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #60734 (9030b1f) into master (69aad85) will increase coverage by 1.07%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #60734      +/-   ##
==========================================
+ Coverage   79.83%   80.91%   +1.07%     
==========================================
  Files        5182     5182              
  Lines      227309   227136     -173     
  Branches    38209    38163      -46     
==========================================
+ Hits       181473   183778    +2305     
+ Misses      40110    37753    -2357     
+ Partials     5726     5605     -121     

see 209 files with indirect coverage changes

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanpurkhiser evanpurkhiser merged commit 5c512ab into master Nov 29, 2023
54 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-devserver-remove-legacy-https-support branch November 29, 2023 20:52
scefali pushed a commit that referenced this pull request Nov 29, 2023
After #60673 we're doing https
proxying via the webpack devserver.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants