Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-map-debug): Make index check more robust #53582

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

roggenkemper
Copy link
Member

this pr adds in a check to make sure frame_idx and exception_idx are integers.

Resolves SENTRY-141S

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #53582 (308145e) into master (aa42364) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #53582   +/-   ##
=======================================
  Coverage   79.48%   79.48%           
=======================================
  Files        4941     4941           
  Lines      209056   209062    +6     
  Branches    35605    35605           
=======================================
+ Hits       166168   166173    +5     
  Misses      37811    37811           
- Partials     5077     5078    +1     
Files Changed Coverage Δ
src/sentry/api/endpoints/source_map_debug.py 95.83% <100.00%> (+0.59%) ⬆️

... and 5 files with indirect coverage changes

@roggenkemper roggenkemper marked this pull request as ready for review July 26, 2023 17:55
@roggenkemper roggenkemper requested a review from a team as a code owner July 26, 2023 17:55
@roggenkemper roggenkemper merged commit 09272ea into master Jul 26, 2023
@roggenkemper roggenkemper deleted the roggenkemper/sourcemapendpointidxfix branch July 26, 2023 18:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants