Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove monitor status initial #47794

Closed
wants to merge 1 commit into from
Closed

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Apr 21, 2023

drafting to see what errors we start hitting

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #47794 (4b64c4b) into master (496b2c5) will decrease coverage by 0.17%.
The diff coverage is 44.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #47794      +/-   ##
==========================================
- Coverage   80.81%   80.65%   -0.17%     
==========================================
  Files        4762     4764       +2     
  Lines      201116   201334     +218     
  Branches    11603    11603              
==========================================
- Hits       162536   162390     -146     
- Misses      38324    38688     +364     
  Partials      256      256              
Impacted Files Coverage Δ
src/sentry/monitors/consumers/check_in.py 61.36% <ø> (-28.18%) ⬇️
...nitors/endpoints/monitor_ingest_checkin_details.py 44.00% <0.00%> (-48.31%) ⬇️
...monitors/endpoints/monitor_ingest_checkin_index.py 72.22% <ø> (-23.67%) ⬇️
src/sentry/monitors/models.py 73.05% <ø> (-22.74%) ⬇️
src/sentry/monitors/serializers.py 86.66% <0.00%> (-13.34%) ⬇️
src/sentry/monitors/tasks.py 37.14% <ø> (-60.16%) ⬇️
static/app/views/profiling/content.tsx 0.00% <ø> (ø)
...c/app/views/profiling/profilingOnboardingPanel.tsx 0.00% <ø> (ø)
static/app/views/replays/detail/noRowRenderer.tsx 0.00% <ø> (ø)
static/app/views/replays/detail/trace/trace.tsx 0.00% <ø> (ø)
... and 2 more

... and 60 files with indirect coverage changes

@rjo100
Copy link
Contributor Author

rjo100 commented Apr 26, 2023

closing in favor of #47910 + follow up work

@rjo100 rjo100 closed this Apr 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
@asottile-sentry asottile-sentry deleted the rjo100/remove-monitor-status branch December 27, 2023 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant