Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onboarding): id badge fix #2 #42158

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix(onboarding): id badge fix #2 #42158

merged 1 commit into from
Dec 8, 2022

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Dec 8, 2022

We should really improve types on this component. If a prop is passes, it shouldn't be allowed to be undefined

@JonasBa JonasBa enabled auto-merge (squash) December 8, 2022 15:55
@JonasBa JonasBa merged commit e70012c into master Dec 8, 2022
@JonasBa JonasBa deleted the jb/project/id-badge branch December 8, 2022 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants