-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - ref(build): Support building Arm64 Docker image #38180
Conversation
In order to install Python's xmlsec package we first need to install this library. This configures Heroku's Apt Buildpack: https://github.com/heroku/heroku-buildpack-apt
It requires a lot of customizations and it's slow. Let's debug the Docker container!
Cloud builds place wheels in a `/dist` directory in order to speed up pip installation
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Bump |
Why don't merge this? |
Because it is not good. This is the Docker image that is used as part of the release work and we cannot be adding hacks (as my comments in the code indicate). I do not have the cycles to work on this. If anyone is willing to take it on feel free. I can guide with reviews. |
It's the end of a long week. Could someone verify if I have something working in here?
You can reproduce the build and run the server like this:
We did manage to produce a Snuba arm64 image in Github's CI. Perhaps we can add something like that later on:
https://github.com/getsentry/snuba/blob/c37a3cc0dabb4c7c0fc31621080b4b75e0a6a8aa/.github/workflows/ci.yml#L134-L192