Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - ref(build): Support building Arm64 Docker image #38180

Closed
wants to merge 47 commits into from

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Aug 26, 2022

It's the end of a long week. Could someone verify if I have something working in here?

You can reproduce the build and run the server like this:

make install-py-dev
sentry devservices up postgres redis
docker build -f docker/Dockerfile -t sentry_arm64 .
docker run --network sentry \
  -e DATABASE_URL=postgresql://postgres:@sentry_postgres:5432/sentry 
  -e SENTRY_REDIS_HOST=sentry_redis \
  -e SENTRY_SECRET_KEY=foo -p 8000:8000 --rm -it sentry_arm64

We did manage to produce a Snuba arm64 image in Github's CI. Perhaps we can add something like that later on:
https://github.com/getsentry/snuba/blob/c37a3cc0dabb4c7c0fc31621080b4b75e0a6a8aa/.github/workflows/ci.yml#L134-L192

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@mrmachine
Copy link

Bump

@long2ice
Copy link

Why don't merge this?

@armenzg
Copy link
Member Author

armenzg commented Dec 14, 2022

Why don't merge this?

Because it is not good. This is the Docker image that is used as part of the release work and we cannot be adding hacks (as my comments in the code indicate). I do not have the cycles to work on this.

If anyone is willing to take it on feel free. I can guide with reviews.

@armenzg armenzg closed this Dec 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
@armenzg armenzg deleted the armenzg/build/arm64-docker branch July 19, 2023 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants