fix(ci): Clone repo with higher depth to fix codecov problems #24211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have had a problem where Codecov either shows too much difference between my PR and master, or no diff at all. Both states have happened within the same PR as Codecov processed new webhooks from GitHub, and in both cases merge commits were involved. With Codecov support I have found that their uploader throws this particular error message, and so let's try giving the uploader more commits so maybe next time it determines the parent commits correctly (?).
billyvg
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had a problem where Codecov either shows too much difference
between my PR and master, or no diff at all. Both states have happened
within the same PR as Codecov processed new webhooks from GitHub, and in
both cases merge commits were involved. With Codecov support I have
found that their uploader throws this particular error message, and
so let's try giving the uploader more commits so maybe next time it
determines the parent commits correctly (?).
In case the actual code diff is wrong, this also has dramatic impact on code coverage, of course. Because you suddenly have uncovered lines in your PR that you didn't touch in the first place.