build(ci): Skip backend test job instead of each step #24198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes backed test workflow to skip at the job level instead of each job step. This simplifies the workflow and more accurately reflects the status of backend tests when backend files change. See getsentry/getsentry#5196 for more details.
|
You can see it properly skipping here where only frontend files were changed: #24199 |
joshuarli
approved these changes
Mar 3, 2021
billyvg
added a commit
that referenced
this pull request
Mar 3, 2021
This reverts commit d8c003f. This doesn't work because of a bug in GH runners: actions/runner#952 Because the backend test has 2 matrix instances, when the job is skipped, it does not create the needed Checks to satisfy our branch protection requirements
billyvg
added a commit
that referenced
this pull request
Mar 3, 2021
…" (#24214) This reverts commit d8c003f. This doesn't work because of a bug in GH runners: actions/runner#952 Because the backend test has 2 matrix instances, when the job is skipped, it does not create the needed Checks to satisfy our branch protection requirements
|
This feels good :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes backed test workflow to skip at the job level instead of each job step.
This simplifies the workflow and more accurately reflects the status of backend tests when backend files change. See https://github.com/getsentry/getsentry/issues/5196 for more details.