fix(tests) Try to stabilize vitals snapshots #22696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web vitals summary snapshots have been a bit flaky lately. Add better loading indicators to charts so we can wait for page transitions better. The `loading-stats` string doesn't exist in the frontend code so the checks we were doing did nothing.
billyvg
approved these changes
Dec 15, 2020
Comment on lines
+12
to
+21
| const TransparentLoadingMask = styled( | ||
| ({className, visible, children, ...props}: Props) => { | ||
| const other = visible ? {...props, 'data-test-id': 'loading-placeholder'} : props; | ||
| return ( | ||
| <LoadingMask className={className} {...other}> | ||
| {children} | ||
| </LoadingMask> | ||
| ); | ||
| } | ||
| )<Props>` |
There was a problem hiding this comment.
Ugh, I hate how noisy this can get when we're mostly just trying to add a prop. Wonder if we should add something like this emotion-js/emotion#821 (comment)
There was a problem hiding this comment.
Yes it is a lot of ceremony for conditionally adding one property.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web vitals summary snapshots have been a bit flaky lately. Add better loading indicators to charts so we can wait for page transitions better. The
loading-statsstring doesn't exist in the frontend code so the checks we were doing did nothing.