Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dif): Add WASM support #22264

Merged
merged 16 commits into from
Dec 1, 2020
Merged

feat(dif): Add WASM support #22264

merged 16 commits into from
Dec 1, 2020

Conversation

mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Nov 24, 2020 •
edited
Loading

Extends the protocol and native processing plugin for WASM support.

Screenshot

image

Dependencies

For this to work the symbolic sentry library also needs to be recompiled with the latest symbolic (or a version containing getsentry/symbolic#166).

Followup Work

  • UI does not deal well with the fact that WASM modules are relatively addressed exclusively and have no size.

@mitsuhiko mitsuhiko requested a review from jan-auer November 24, 2020 20:53
@mitsuhiko mitsuhiko changed the title feat(dif): Added WASM support to difs feat(dif): Added WASM support Nov 24, 2020
@mitsuhiko mitsuhiko marked this pull request as ready for review November 24, 2020 23:37
@mitsuhiko mitsuhiko mentioned this pull request Nov 26, 2020
Merged
@mitsuhiko mitsuhiko requested a review from a team as a code owner November 27, 2020 11:55
BYK
BYK reviewed Nov 27, 2020
View reviewed changes
scripts/ensure-venv.sh Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2020 •
edited
Loading

size-limit report

Path Size
public/app.js 277.4 KB (+0.05% 🔺)
public/vendor.js 594.46 KB (0%)
public/sentry.css 33.49 KB (0%)

@jan-auer jan-auer changed the title feat(dif): Added WASM support feat(dif): Add WASM support Nov 28, 2020
@mitsuhiko mitsuhiko requested a review from a team as a code owner November 30, 2020 19:14
jan-auer
jan-auer approved these changes Nov 30, 2020
View reviewed changes
src/sentry/lang/native/processing.py Outdated Show resolved Hide resolved
src/sentry/lang/native/processing.py Outdated Show resolved Hide resolved
@mitsuhiko mitsuhiko requested a review from jan-auer December 1, 2020 14:03
@mitsuhiko mitsuhiko merged commit 8b8f3e5 into master Dec 1, 2020
@mitsuhiko mitsuhiko deleted the feature/wasm branch December 1, 2020 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BYK BYK BYK left review comments

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitsuhiko @BYK @jan-auer