Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance) Add related issues endpoint #18344

Merged
merged 6 commits into from
Apr 24, 2020

Conversation

evanh
Copy link
Member

@evanh evanh commented Apr 17, 2020

A first pass at a related issues endpoint to be used by the transaction summary
page to show issues related to that transaction.

A first pass at a related issues endpoint to be used by the transaction summary
page to show issues related to that transaction.
@evanh evanh requested a review from a team April 17, 2020 20:05
src/sentry/api/endpoints/organization_events_meta.py Outdated Show resolved Hide resolved
src/sentry/snuba/discover.py Outdated Show resolved Hide resolved
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff, but I think this is a good first pass to try related issues

src/sentry/api/endpoints/organization_events_meta.py Outdated Show resolved Hide resolved
src/sentry/snuba/discover.py Outdated Show resolved Hide resolved
from sentry.snuba import discover


IssueSeach = EventsDatasetSnubaSearchBackend(**settings.SENTRY_SEARCH_OPTIONS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we don't build specific backends, and use the search proxy instead.

from sentry import search
results = search.query(...)

I saw that this is also being done the way you have it in OrganizationGroupIndex. Perhaps @iProgramStuff knows why we're using a specific backend there?

@evanh evanh merged commit b458e8e into master Apr 24, 2020
@evanh evanh deleted the evanh/feat/related-issues-transaction-summary branch April 24, 2020 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants