Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Refine development hydration breadcrumb regex #61943

Closed
Tracked by #59564
scttcper opened this issue Dec 18, 2023 · 0 comments · Fixed by getsentry/sentry-javascript#9922
Closed
Tracked by #59564

[SDK] Refine development hydration breadcrumb regex #61943

scttcper opened this issue Dec 18, 2023 · 0 comments · Fixed by getsentry/sentry-javascript#9922

Comments

@scttcper
Copy link
Member

scttcper commented Dec 18, 2023 •
edited
Loading

The development regex is too broad and catching things that are not hydration errors.

https://github.com/getsentry/sentry-javascript/blob/f1a677f88f7136435b8fe22b615256482ead4720/packages/replay/src/coreHandlers/handleBeforeSendEvent.ts#L35

ACs:

  • Restrict the regex further "did not match" is not specific enough
This was referenced Dec 18, 2023
Closed
Merged
scttcper added a commit to getsentry/sentry-javascript that referenced this issue Dec 19, 2023
@scttcper
fix(replay): Adjust development hydration error messages (#9922)
2d69912 
Refine the regex to match fewer errors, seeing some false positives in
replays that are not hydration errors.

fixes getsentry/sentry#61943
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(replay): Adjust development hydration error messages getsentry/sentry-javascript
1 participant
@scttcper