Skip to content

Commit

Permalink
ref: remove requires_not_arm64 (#82093)
Browse files Browse the repository at this point in the history
these tests pass now on arm64 -- presumably because we no longer have
version drift for clickhouse

<!-- Describe your PR here. -->
  • Loading branch information
asottile-sentry authored Dec 13, 2024
1 parent 4e3eed6 commit 33b8a62
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
9 changes: 0 additions & 9 deletions src/sentry/testutils/skips.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,6 @@
T = TypeVar("T", bound=Callable[..., Any])


def is_arm64() -> bool:
return os.uname().machine == "arm64"


requires_not_arm64 = pytest.mark.skipif(
is_arm64(), reason="this test fails in our arm64 testing env"
)


def xfail_if_not_postgres(reason: str) -> Callable[[T], T]:
def decorator(function: T) -> T:
return pytest.mark.xfail(os.environ.get("TEST_SUITE") != "postgres", reason=reason)(
Expand Down
3 changes: 0 additions & 3 deletions tests/snuba/api/endpoints/test_organization_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
from sentry.testutils.helpers import parse_link_header
from sentry.testutils.helpers.datetime import before_now, freeze_time, iso_format
from sentry.testutils.helpers.discover import user_misery_formula
from sentry.testutils.skips import requires_not_arm64
from sentry.types.group import GroupSubStatus
from sentry.utils import json
from sentry.utils.samples import load_data
Expand Down Expand Up @@ -3373,7 +3372,6 @@ def test_all_aggregates_in_columns(self):
assert data[0]["linear_regression(transaction.duration, transaction.duration)"] == [0, 0]
assert data[0]["sum(transaction.duration)"] == 10000

@requires_not_arm64
def test_null_user_misery_returns_zero(self):
self.transaction_data["user"] = None
self.transaction_data["transaction"] = "/no_users/1"
Expand All @@ -3393,7 +3391,6 @@ def test_null_user_misery_returns_zero(self):
data = response.data["data"]
assert data[0]["user_misery(300)"] == 0

@requires_not_arm64
def test_null_user_misery_new_returns_zero(self):
self.transaction_data["user"] = None
self.transaction_data["transaction"] = "/no_users/1"
Expand Down

0 comments on commit 33b8a62

Please sign in to comment.