Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rn): Add code snippet to send the first Sentry Error #263

Merged
merged 5 commits into from
Apr 28, 2023
Merged

feat(rn): Add code snippet to send the first Sentry Error #263

merged 5 commits into from
Apr 28, 2023

Conversation

krystofwoldrich
Copy link
Member

@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ab3f92d

krystofwoldrich
krystofwoldrich commented Apr 26, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
kahest
kahest reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition 🚀 left some wording suggestions.

lib/Steps/Integrations/ReactNative.ts Outdated Show resolved Hide resolved
lib/Steps/Integrations/ReactNative.ts Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich requested a review from scefali April 26, 2023 14:03
@krystofwoldrich @kahest
Apply suggestions from code review
2da5617 
Co-authored-by: Karl Heinz Struggl <[email protected]>
kahest
kahest approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small notes, otherwise LGTM!

lib/Steps/Integrations/ReactNative.ts Outdated Show resolved Hide resolved
lib/Steps/Integrations/ReactNative.ts Show resolved Hide resolved
@krystofwoldrich krystofwoldrich merged commit 1520bab into master Apr 28, 2023
@krystofwoldrich krystofwoldrich deleted the kw-rn-code-snippet branch April 28, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahest kahest kahest approved these changes

@scefali scefali Awaiting requested review from scefali

@marandaneto marandaneto Awaiting requested review from marandaneto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[react-native] Setup flow should prompt user to trigger first error event
3 participants
@krystofwoldrich @kahest @marandaneto