Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop -a --only Style/StringLiterals #2373

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Aug 15, 2024

Turned out this was the only offense here :)

#skip-changelog

@solnic solnic requested a review from sl0thentr0py August 15, 2024 06:25
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 96.63866% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (fa0973a) to head (6434e2c).
Report is 1 commits behind head on master.

Files Patch % Lines
sentry-ruby/lib/sentry/rake.rb 0.00% 2 Missing ⚠️
sentry-ruby/lib/sentry/graphql.rb 0.00% 1 Missing ⚠️
sentry-ruby/lib/sentry/interfaces/request.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2373   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         209      209           
  Lines       13861    13861           
=======================================
+ Hits        13681    13682    +1     
+ Misses        180      179    -1     
Components Coverage Δ
sentry-ruby 99.06% <96.63%> (ø)
sentry-rails 97.43% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 97.11% <ø> (+0.32%) ⬆️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 96.71% <100.00%> (ø)
sentry-ruby/lib/sentry/attachment.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/baggage.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb/sentry_logger.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/check_in_event.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.81% <100.00%> (ø)
sentry-ruby/lib/sentry/core_ext/object/deep_dup.rb 94.11% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_check_ins.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_config.rb 100.00% <100.00%> (ø)
... and 23 more

... and 3 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit ec70677 into master Aug 16, 2024
125 of 127 checks passed
@sl0thentr0py sl0thentr0py deleted the solnic/style-fix-quotes branch August 16, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants