-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Net::HTTP and Faraday implementations #2360
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2360 +/- ##
==========================================
+ Coverage 98.68% 98.69% +0.01%
==========================================
Files 207 208 +1
Lines 13741 13748 +7
==========================================
+ Hits 13560 13569 +9
+ Misses 181 179 -2
|
7c83e6f
to
259f223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one comment
259f223
to
3549d8d
Compare
def propagate_trace?(url) | ||
url && | ||
Sentry.initialized? && | ||
Sentry.configuration.propagate_traces && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sl0thentr0py given that direct access to the configuration is not thread-safe, we could have a method for checking configuration values that would perform this additonal initialize?
check, something like:
Sentry.configuration(:propagate_traces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to to add a helper but the semantics of that (truthy or falsey?) are not always clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
Bonus refa after #2345
nil
if Sentry is not initialized instead of issuing a request. See 259f223#skip-changelog